Potential fix for code scanning alert no. 6: Workflow does not contain permissions#37
Merged
albertomandlate merged 1 commit intomainfrom May 22, 2025
Merged
Potential fix for code scanning alert no. 6: Workflow does not contain permissions#37albertomandlate merged 1 commit intomainfrom
albertomandlate merged 1 commit intomainfrom
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds minimal permissions to the GitHub Actions workflow to address the code scanning alert regarding missing permissions.
- Introduces a root-level
permissionsblock grantingcontents: readby default. - Overrides permissions in the NuGet publishing step to
packages: write.
Comment on lines
+61
to
+62
| permissions: | ||
| packages: write |
There was a problem hiding this comment.
The permissions block is defined under a step, but GitHub Actions only supports permissions at the workflow or job level. Move this packages: write override to the job definition for the NuGet publishing job.
Suggested change
| permissions: | |
| packages: write |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/SimansoftMZ/SAF-T/security/code-scanning/6
To fix the issue, we will add a
permissionsblock at the root of the workflow to define the minimal permissions required for the workflow. Most steps in the workflow only requirecontents: read, but the step that publishes to NuGet requirespackages: write. We will setcontents: readat the root level and override it withpackages: writefor the specific job that publishes to NuGet.Suggested fixes powered by Copilot Autofix. Review carefully before merging.